Skip to content

chore(demo): add custom notification sound support#1926

Merged
fadi-george merged 3 commits intomainfrom
fg/update-example
Mar 18, 2026
Merged

chore(demo): add custom notification sound support#1926
fadi-george merged 3 commits intomainfrom
fg/update-example

Conversation

@fadi-george
Copy link
Copy Markdown
Collaborator

@fadi-george fadi-george commented Mar 18, 2026

Description

One Line Summary

Add "WITH SOUND" push notification button to the demo app, document sound file setup, and harden the setup script.

Details

Motivation

The demo app was missing the "WITH SOUND" notification type specified in the shared demo build spec. This aligns the React Native demo with the Expo plugin demo (bff6ac79).

Scope

  • Demo app: Adds WithSound notification type that sends a push with ios_sound: "vine_boom.wav" and android_channel_id for custom sound playback
  • Sound file: Bundles vine_boom.wav in iOS app bundle (ios/demo/) and Android res/raw/, plus Xcode project configuration
  • Build docs: Documents sound file placement paths for both platforms in examples/build.md
  • Setup script: Adds set -euo pipefail for fail-fast behavior and fixes stale tgz cleanup glob
  • No SDK changes

Testing

Manual testing

  • Verified the "WITH SOUND" button sends a notification with custom sound on both iOS and Android
  • iOS: sound plays correctly via ios_sound parameter
  • Android: sound plays correctly after fresh install (channel created with vine_boom from res/raw/). Note: if the app was previously installed without the sound file, uninstall first so Android recreates the notification channel.
Screenshot 2026-03-17 at 6 19 48 PM Screenshot 2026-03-18 at 3 49 00 PM

Affected code checklist

  • Notifications
    • Display

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

@fadi-george fadi-george requested a review from a team as a code owner March 18, 2026 22:50
@fadi-george fadi-george merged commit 45095e3 into main Mar 18, 2026
10 checks passed
@fadi-george fadi-george deleted the fg/update-example branch March 18, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants