chore(demo): add custom notification sound support#1926
Merged
fadi-george merged 3 commits intomainfrom Mar 18, 2026
Merged
Conversation
sherwinski
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add "WITH SOUND" push notification button to the demo app, document sound file setup, and harden the setup script.
Details
Motivation
The demo app was missing the "WITH SOUND" notification type specified in the shared demo build spec. This aligns the React Native demo with the Expo plugin demo (bff6ac79).
Scope
WithSoundnotification type that sends a push withios_sound: "vine_boom.wav"andandroid_channel_idfor custom sound playbackvine_boom.wavin iOS app bundle (ios/demo/) and Androidres/raw/, plus Xcode project configurationexamples/build.mdset -euo pipefailfor fail-fast behavior and fixes stale tgz cleanup globTesting
Manual testing
ios_soundparametervine_boomfromres/raw/). Note: if the app was previously installed without the sound file, uninstall first so Android recreates the notification channel.Affected code checklist
Checklist
Overview
Testing
Final pass